Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove random from standard functions to promote reliability #47

Closed
Tracked by #49
cshaa opened this issue Sep 17, 2021 · 0 comments
Closed
Tracked by #49

Remove random from standard functions to promote reliability #47

cshaa opened this issue Sep 17, 2021 · 0 comments
Labels
design An issue regarding the user experience implemented This feature is implemented in `develop` and ready for testing
Milestone

Comments

@cshaa
Copy link
Owner

cshaa commented Sep 17, 2021

The ideal filtrex expression should be reliable and return the same result every time it is evaluated. Letting the user call Math.random() by default goes against this principle and might lead to pathological applications states – imagine filtering a paginated list based on a random criterion.

Therefore, the random() function will be removed in v3. Anyone who needs it can pass it as a custom function.

@cshaa cshaa added design An issue regarding the user experience implemented This feature is implemented in `develop` and ready for testing labels Sep 17, 2021
@cshaa cshaa added this to the v3 milestone Sep 17, 2021
cshaa added a commit that referenced this issue Sep 17, 2021
@cshaa cshaa closed this as completed Sep 17, 2021
@cshaa cshaa mentioned this issue Sep 17, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design An issue regarding the user experience implemented This feature is implemented in `develop` and ready for testing
Projects
None yet
Development

No branches or pull requests

1 participant