forked from apache/accumulo
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
8 changed files
with
265 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
133 changes: 133 additions & 0 deletions
133
server/manager/src/main/java/org/apache/accumulo/manager/merge/FindMergeableTask.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.accumulo.manager.merge; | ||
|
|
||
| import java.util.Map; | ||
| import java.util.Map.Entry; | ||
| import java.util.Objects; | ||
|
|
||
| import org.apache.accumulo.core.clientImpl.thrift.TableOperation; | ||
| import org.apache.accumulo.core.conf.Property; | ||
| import org.apache.accumulo.core.data.NamespaceId; | ||
| import org.apache.accumulo.core.data.TableId; | ||
| import org.apache.accumulo.core.dataImpl.KeyExtent; | ||
| import org.apache.accumulo.core.fate.Fate.FateOperation; | ||
| import org.apache.accumulo.core.fate.FateInstanceType; | ||
| import org.apache.accumulo.manager.Manager; | ||
| import org.apache.accumulo.manager.tableOps.TraceRepo; | ||
| import org.apache.accumulo.manager.tableOps.merge.MergeInfo; | ||
| import org.apache.accumulo.manager.tableOps.merge.TableRangeOp; | ||
| import org.apache.accumulo.manager.tableOps.merge.UnreserveAndError; | ||
| import org.apache.commons.lang3.StringUtils; | ||
| import org.apache.hadoop.io.Text; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| import static org.apache.accumulo.core.metadata.schema.TabletMetadata.ColumnType.FILES; | ||
| import static org.apache.accumulo.core.metadata.schema.TabletMetadata.ColumnType.MERGEABILITY; | ||
|
|
||
| public class FindMergeableTask implements Runnable { | ||
|
|
||
| private static final Logger log = LoggerFactory.getLogger(FindMergeableTask.class); | ||
| private final Manager manager; | ||
|
|
||
| public FindMergeableTask(Manager manager) { | ||
| this.manager = Objects.requireNonNull(manager); | ||
| } | ||
|
|
||
| @Override | ||
| public void run() { | ||
| var context = manager.getContext(); | ||
| var tableOp = TableOperation.MERGE; | ||
| Map<TableId,String> tables = context.getTableIdToNameMap(); | ||
|
|
||
| for (Entry<TableId,String> table : tables.entrySet()) { | ||
| TableId tableId = table.getKey(); | ||
| String tableName = table.getValue(); | ||
|
|
||
| long maxFiles = context.getTableConfiguration(tableId) | ||
| .getCount(Property.TABLE_MERGE_FILE_MAX); | ||
| long threshold = context.getTableConfiguration(tableId) | ||
| .getAsBytes(Property.TABLE_SPLIT_THRESHOLD); | ||
| double mergeabilityThreshold = .25; | ||
| long maxTotalSize = (long) (threshold * mergeabilityThreshold); | ||
|
|
||
|
|
||
| try { | ||
| NamespaceId namespaceId = context.getNamespaceId(tableId); | ||
| var type = FateInstanceType.fromTableId(tableId); | ||
|
|
||
| try (var tablets = context.getAmple().readTablets().forTable(tableId) | ||
| .fetch(FILES, MERGEABILITY).checkConsistency().build()) { | ||
|
|
||
| long totalFiles = 0; | ||
| long totalSize = 0; | ||
| var currentTime = manager.getSteadyTime(); | ||
| //boolean mergeable = true; | ||
|
|
||
| Text startRow = null; | ||
| Text endRow = null; | ||
|
|
||
| boolean mergeable = false; | ||
| for (var tabletMetadata : tablets) { | ||
|
|
||
| if (!tabletMetadata.getTabletMergeability().isMergeable(currentTime)) { | ||
| mergeable = false; | ||
| } | ||
|
|
||
| totalFiles += tabletMetadata.getFiles().size(); | ||
| if (totalFiles >= maxFiles) { | ||
| //log.debug("{} found {} files in the merge range, maxFiles is {}", fateId, totalFiles, | ||
| // maxFiles); | ||
| mergeable = false; | ||
| } | ||
|
|
||
| totalSize += tabletMetadata.getFileSize(); | ||
| if (totalSize > maxTotalSize) { | ||
| mergeable = false; | ||
| } | ||
|
|
||
| if (!mergeable) { | ||
|
|
||
| } | ||
| } | ||
|
|
||
| } | ||
|
|
||
| Text startRow = new Text(); | ||
| Text endRow = new Text(); | ||
| String startRowStr = StringUtils.defaultIfBlank(startRow.toString(), "-inf"); | ||
| String endRowStr = StringUtils.defaultIfBlank(startRow.toString(), "+inf"); | ||
| log.debug("Creating merge op: {} from startRow: {} to endRow: {}", tableId, startRowStr, | ||
| endRowStr); | ||
| var fateId = manager.fate(type).startTransaction(); | ||
| String goalMessage = tableOp + " Merge table " + tableName + "(" + tableId | ||
| + ") splits from " + startRowStr + " to " + endRowStr; | ||
|
|
||
| manager.fate(type).seedTransaction(FateOperation.SYSTEM_MERGE, fateId, new TraceRepo<>( | ||
| new TableRangeOp(MergeInfo.Operation.MERGE, namespaceId, tableId, startRow, endRow)), | ||
| true, goalMessage); | ||
| } catch (Exception e) { | ||
| log.error("Failed to generate system merges for {}", tableName, e); | ||
| } | ||
| } | ||
|
|
||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99 changes: 99 additions & 0 deletions
99
.../manager/src/main/java/org/apache/accumulo/manager/tableOps/merge/VerifyMergeability.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.accumulo.manager.tableOps.merge; | ||
|
|
||
| import static org.apache.accumulo.core.metadata.schema.TabletMetadata.ColumnType.FILES; | ||
| import static org.apache.accumulo.core.metadata.schema.TabletMetadata.ColumnType.MERGEABILITY; | ||
|
|
||
| import org.apache.accumulo.core.conf.Property; | ||
| import org.apache.accumulo.core.fate.FateId; | ||
| import org.apache.accumulo.core.fate.Repo; | ||
| import org.apache.accumulo.manager.Manager; | ||
| import org.apache.accumulo.manager.tableOps.ManagerRepo; | ||
| import org.apache.accumulo.manager.tableOps.merge.MergeInfo.Operation; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| import com.google.common.base.Preconditions; | ||
|
|
||
| public class VerifyMergeability extends ManagerRepo { | ||
| private static final Logger log = LoggerFactory.getLogger(VerifyMergeability.class); | ||
| private static final long serialVersionUID = 1L; | ||
| private final MergeInfo data; | ||
|
|
||
| // Only used for System merges | ||
| VerifyMergeability(MergeInfo mergeInfo) { | ||
| this.data = mergeInfo; | ||
| Preconditions.checkArgument(data.op == Operation.SYSTEM_MERGE, "Must be a System Merge"); | ||
| } | ||
|
|
||
| @Override | ||
| public Repo<Manager> call(FateId fateId, Manager env) throws Exception { | ||
|
|
||
| var range = data.getReserveExtent(); | ||
|
|
||
| var currentTime = env.getSteadyTime(); | ||
| var context = env.getContext(); | ||
| var tableConf = context.getTableConfiguration(data.tableId); | ||
| var threshold = tableConf.getAsBytes(Property.TABLE_SPLIT_THRESHOLD); | ||
|
|
||
| // max percentage of split threshold | ||
| double mergeabilityThreshold = .25; | ||
| long maxTotalSize = (long) (threshold * mergeabilityThreshold); | ||
| long totalFiles = 0; | ||
|
|
||
| long maxFiles = env.getContext().getTableConfiguration(data.getOriginalExtent().tableId()) | ||
| .getCount(Property.TABLE_MERGE_FILE_MAX); | ||
|
|
||
| try (var tablets = env.getContext().getAmple().readTablets().forTable(data.tableId) | ||
| .overlapping(range.prevEndRow(), range.endRow()).fetch(FILES, MERGEABILITY) | ||
| .checkConsistency().build()) { | ||
|
|
||
| boolean mergeable = true; | ||
| long totalSize = 0; | ||
|
|
||
| for (var tabletMetadata : tablets) { | ||
| if (!tabletMetadata.getTabletMergeability().isMergeable(currentTime)) { | ||
| mergeable = false; | ||
| } | ||
|
|
||
| totalFiles += tabletMetadata.getFiles().size(); | ||
| if (totalFiles >= maxFiles) { | ||
| log.debug("{} found {} files in the merge range, maxFiles is {}", fateId, totalFiles, | ||
| maxFiles); | ||
| mergeable = false; | ||
| } | ||
|
|
||
| totalSize += tabletMetadata.getFileSize(); | ||
| if (totalSize > maxTotalSize) { | ||
| mergeable = false; | ||
| } | ||
|
|
||
| if (!mergeable) { | ||
| // TODO: update UnreserveAndError to pass reason, not always max files | ||
| return new UnreserveAndError(data, totalFiles, 0); | ||
| } | ||
| } | ||
|
|
||
| } | ||
|
|
||
| return new MergeTablets(data); | ||
| } | ||
|
|
||
| } |