feat(imagor): Expire Filter: Cache-Control response header #376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, any request which used the
expire()
filter always setCache-Control: "private, no-cache, no-store, must-revalidate"
in the response.As discussed here, it would be nice to be able to cache these responses in the browser, up to the expiry timestamp or imagor's configured cache ttl - whichever of the 2 is sooner.
This pull request makes the following changes:
Cache-Control: private
header, if present in the request and set the response Cache-Control header accordinglyexpire()
filter is used (assume resources with expiry are more sensitive and only to be cached privately)