s3: storage class for files in result storage bucket #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f100024
force-pushed
the
add-s3-storage-class
branch
from
9a8400d to
ec43b63
Compare
cshum
reviewed
Oct 10, 2023
storage/s3storage/option.go
Outdated
|
|
||
| func WithFileStorageClass(storageClass string) Option { | ||
| return func(h *S3Storage) { | ||
| switch storageClass { |
There was a problem hiding this comment.
Seems clearer and simpler keeping the string as it is?
i.e. REDUCED_REDUNDANCY, STANDARD_IA etc
cshum
reviewed
Oct 11, 2023
config/awsconfig/awsconfig.go
Outdated
| @@ -90,6 +91,8 @@ func WithAWS(fs *flag.FlagSet, cb func() (*zap.Logger, bool)) imagor.Option { | |||
| "Upload ACL for S3 Result Storage") | |||
| s3ResultStorageExpiration = fs.Duration("s3-result-storage-expiration", 0, | |||
| "S3 Result Storage expiration duration e.g. 24h. Default no expiration") | |||
| s3FileStorageClass = fs.String("s3-file-storage-class", "STANDARD", | |||
There was a problem hiding this comment.
better rename to s3StorageClass, s3-storage-class? As file storage would result confusion with file system storage.
There was a problem hiding this comment.
should also add storage class to s3 storage, not only result storage. See
https://github.com/cshum/imagor/pull/402/files#diff-f58e37fdae6c04a8b5d1c70ee04a0c95bbab1a4f55ad66f0ee69796b8fd4730cR165
There was a problem hiding this comment.
Add test case around https://github.com/cshum/imagor/blob/master/config/awsconfig/awsconfig_test.go
- default should expect
STANDARD - a valid setting e.g.
REDUCED_REDUNDANCY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More about Storage Class:
https://docs.aws.amazon.com/AmazonS3/latest/dev/storage-class-intro.html
Briefly from
aws-sdk-go: