Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include supported capabilities in CSIAddonsNode status output #376

Closed
nixpanic opened this issue Jun 21, 2023 · 1 comment · Fixed by #635
Closed

Include supported capabilities in CSIAddonsNode status output #376

nixpanic opened this issue Jun 21, 2023 · 1 comment · Fixed by #635
Assignees
@black-dragon74
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nixpanic
Copy link
Collaborator

The CSIAddonsNode object contains details about the node and CSI-driver that provides a set of CSI-Addons features. It would be useful for debugging and validation to have the capabilities (from CSI-Addons Identity service) listed in the Status field of the CSIAddonsNode CR.

This could be done on the initial connection to the csi-addons-sidecar, at

https://github.com/csi-addons/kubernetes-csi-addons/blob/493222166f4132a930137e03ba51960319cf39d0/controllers/csiaddons/csiaddonsnode_controller.go#L138C44-L144
@nixpanic nixpanic added enhancement New feature or request good first issue Good for newcomers labels Jun 21, 2023
@black-dragon74
Copy link
Member

/assign @black-dragon74

black-dragon74 added a commit to black-dragon74/kubernetes-csi-addons that referenced this issue Aug 6, 2024
@black-dragon74
Include capabilities in CSIAddonsNode status
bf199c6 
This patch adds support to display advertised
capabilities in the status field of CSIAddonsNode

Closes: csi-addons#376

Signed-off-by: Niraj Yadav <niryadav@redhat.com>
black-dragon74 added a commit to black-dragon74/kubernetes-csi-addons that referenced this issue Aug 6, 2024
@black-dragon74
Include capabilities in CSIAddonsNode status
0038360 
This patch adds support to display advertised
capabilities in the status field of CSIAddonsNode

Closes: csi-addons#376

Signed-off-by: Niraj Yadav <niryadav@redhat.com>
@black-dragon74 black-dragon74 mentioned this issue Aug 6, 2024
Merged
black-dragon74 added a commit to black-dragon74/kubernetes-csi-addons that referenced this issue Aug 8, 2024
@black-dragon74
Include capabilities in CSIAddonsNode status
5983673 
This patch adds support to display advertised
capabilities in the status field of CSIAddonsNode

Closes: csi-addons#376

Signed-off-by: Niraj Yadav <niryadav@redhat.com>
black-dragon74 added a commit to black-dragon74/kubernetes-csi-addons that referenced this issue Aug 8, 2024
@black-dragon74
Include capabilities in CSIAddonsNode status
5ae0761 
This patch adds support to display advertised
capabilities in the status field of CSIAddonsNode

Closes: csi-addons#376

Signed-off-by: Niraj Yadav <niryadav@redhat.com>
black-dragon74 added a commit to black-dragon74/kubernetes-csi-addons that referenced this issue Aug 8, 2024
@black-dragon74
Include capabilities in CSIAddonsNode status
13993e5 
This patch adds support to display advertised
capabilities in the status field of CSIAddonsNode

Closes: csi-addons#376

Signed-off-by: Niraj Yadav <niryadav@redhat.com>
nixpanic pushed a commit to black-dragon74/kubernetes-csi-addons that referenced this issue Aug 14, 2024
@black-dragon74 @nixpanic
Include capabilities in CSIAddonsNode status
97f0ff5 
This patch adds support to display advertised
capabilities in the status field of CSIAddonsNode

Closes: csi-addons#376

Signed-off-by: Niraj Yadav <niryadav@redhat.com>
@mergify mergify bot closed this as completed in #635 Aug 14, 2024
@mergify mergify bot closed this as completed in 230f81d Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@black-dragon74 black-dragon74

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include capabilities in CSIAddonsNode status black-dragon74/kubernetes-csi-addons
2 participants
@nixpanic @black-dragon74