-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: GitHub workflows fail to build container-images for multiple architectures #92
Comments
Maybe there is some GitHub access limitation:
The user creating the PR, will not have access to edit the file directly. Creating a PR from a branch in the local repository (#90) did work. That branch might have "access to edit the file"? |
The behaviour is intentional and documented in a GitHub security guide:
We'll need to think of an other way to limit building for multiple platforms. |
Yes due to security reason its done, sorry i forgot about it :( do we need to revert back to the PR introduced this one? |
Reverting is probably not needed. The builds after merging build all platforms, so that is fine for now. I'd like some way of configuring it in a single place, so that it is easy to adjust in forks of this repo. Just not sure what/where that configuration should be done. |
Syncing latest changes from main for kubernetes-csi-addons
#89 changed how architectures are passed to the GitHub workflows. It seems that #91 was built only on one platform, instead of linux/amd64, linux/arm64 and linux/arm/v7.
For some reason the
secrets.BUILD_PLATFORMS
does not seem to be set for GitHub Actions?The text was updated successfully, but these errors were encountered: