reclaimspace: detect Kubernetes version for right StagingTargetPath #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubernetes 1.24 and newer use a different path for staging the volume. That means the CSI-driver is requested to mount the volume at an other location, compared to previous versions of Kubernetes. CSI-drivers implementing the CSI-Addons NodeReclaimSpace procedure, must receive the correct path, otherwise the driver will not be able to free space and possibly return an error. See-also: kubernetes/kubernetes#107065 See-also: https://bugzilla.redhat.com/2096209 Signed-off-by: Niels de Vos <ndevos@redhat.com>
nixpanic
force-pushed
the
reclaimspace/k8s-1.24/staging-path
branch
from
9351866
to
1bbc6c1
Compare
Kubernetes versions < 1.24 should use the `-legacy` option, newer versions require `-drivername` to build the StagingTargetPath where the volume is mounted. Signed-off-by: Niels de Vos <ndevos@redhat.com>
nixpanic
force-pushed
the
reclaimspace/k8s-1.24/staging-path
branch
from
1bbc6c1
to
1f63bfc
Compare
Rakshith-R
requested changes
Jun 15, 2022
| @@ -83,7 +84,17 @@ func (nrs *NodeReclaimSpace) Init(c *command) error { | |||
| if c.stagingPath == "" { | |||
| return fmt.Errorf("stagingpath is not set") | |||
| } | |||
| nrs.stagingTargetPath = fmt.Sprintf("%s/%s/globalmount", c.stagingPath, c.persistentVolume) | |||
|
|
|||
| if !c.legacy { | |||
There was a problem hiding this comment.
Can we not do with only kube server version check?
Do we need another bool legacy parameter?
Maybe I am missing something 🤔
There was a problem hiding this comment.
we could, but the command does not use any Kubernetes client at all, it is intended to be functional outside of Kubernetes too.
There was a problem hiding this comment.
Okay,
If it can run seamlessly on k8s version less than 1.24 than I am fine.
Or do we need to tweak legacy variable depending on the k8s version too?
(This change will need to go into rook)
There was a problem hiding this comment.
okay this is for the testing tool 🤦 my bad
Rakshith-R
approved these changes
Jun 15, 2022
yati1998
approved these changes
Jun 15, 2022
4 tasks
Rakshith-R
pushed a commit
to Rakshith-R/kubernetes-csi-addons
that referenced
this pull request
Sep 2, 2024
Syncing latest changes from main for kubernetes-csi-addons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes 1.24 and newer use a different path for staging the volume.
That means the CSI-driver is requested to mount the volume at an other
location, compared to previous versions of Kubernetes. CSI-drivers
implementing the CSI-Addons NodeReclaimSpace procedure, must receive the
correct path, otherwise the driver will not be able to free space and
possibly return an error.
See-also: kubernetes/kubernetes#107065
See-also: https://bugzilla.redhat.com/2096209