build: support OwnNamespace installMode type #286
Conversation
Rakshith-R
force-pushed
the
support-OwnNamespace
branch
2 times, most recently
from
331ecb8
to
c118bed
Compare
We currently don't have a conversion webhook, therefore can support the OwnNamespace installMode type too. This change was done by default when webhook support was added. Signed-off-by: Rakshith R <rar@redhat.com>
Rakshith-R
force-pushed
the
support-OwnNamespace
branch
from
c118bed
to
1f7b84f
Compare
| @@ -52,8 +52,7 @@ spec: | |||
| deployments: null | |||
| strategy: "" | |||
| installModes: | |||
| # CSVs featuring a conversion webhook can only support the AllNamespaces install mode | |||
| - supported: false | |||
| - supported: true | |||
There was a problem hiding this comment.
since we don't have conversion for any CRDs, we can support OwnNamespace installmode.
There was a problem hiding this comment.
Is is problematic for a deployment with OwnNamespace, and we introduce conversion webhooks later on? Can that deployment move to AllNamespaces?
There was a problem hiding this comment.
Is is problematic for a deployment with OwnNamespace, and we introduce conversion webhooks later on? Can that deployment move to AllNamespaces?
That's the exact problem being faced right now.
OLM has no way to automatically upgrade operator group which influences installModes
https://olm.operatorframework.io/docs/advanced-tasks/operator-scoping-with-operatorgroups/
This operator group is installed by admin/UI, will need to manually changed/ discussed with olm devs.
But for now, we don't need to put this restriction since we don't have conversion webhooks right now.
| #- patches/webhook_in_volumereplicationclasses.yaml | ||
| #+kubebuilder:scaffold:crdkustomizewebhookpatch | ||
|
|
||
| # [CERTMANAGER] To enable cert-manager, uncomment all the sections with [CERTMANAGER] prefix. | ||
| # patches here are for enabling the CA injection for each CRD | ||
| #- patches/cainjection_in_csiaddonsnodes.yaml | ||
| #- patches/cainjection_in_reclaimspacejobs.yaml | ||
| #- patches/cainjection_in_volumereplications.yaml | ||
| - patches/cainjection_in_volumereplicationclasses.yaml | ||
| #- patches/cainjection_in_volumereplicationclasses.yaml |
There was a problem hiding this comment.
This should be uncommitted for enabling webhook conversion,
since we don't have conversion for any CRDs, we don't need this.
|
I've tested this pr and it works fine, |
There was a problem hiding this comment.
Yes, this is good to go, To summarize, this is not a must for upstream, and no harm in keeping it also and this is a kind of temporary fix for downstream builds. If we add support for conversion webhooks in the future, the ODF should fix the way it's installing the CSI-addons operator right?
We don't need to have this restriction at the moment. |
We currently don't have a conversion webhook,
therefore can support the OwnNamespace installMode type too.
This change was done by default when webhook support was added.
Signed-off-by: Rakshith R rar@redhat.com