Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIGS Demo Notebook Update #158

Merged
merged 5 commits into from
Oct 10, 2023
Merged

FIGS Demo Notebook Update #158

merged 5 commits into from
Oct 10, 2023

Conversation

mepland
Copy link
Collaborator

@mepland mepland commented Jan 1, 2023

@csinva let's wait on merging this for a few weeks, until both imodels and dtreeviz release new minor versions. I have a few changes I want to make then:

  • Remove path to ~/imodels
  • Use 'leaftype': 'barh'
  • Update color scheme
  • Possibly add numeric leaf predictions and split visualizations

@mepland mepland marked this pull request as ready for review October 10, 2023 03:29
@mepland
Copy link
Collaborator Author

mepland commented Oct 10, 2023

@csinva sorry this took a long time, but here are the updates!
I will leave "Possibly add numeric leaf predictions and split visualizations" for a later PR.

Addresses #161.

@mepland mepland mentioned this pull request Oct 10, 2023
Closed
@csinva
Copy link
Owner

csinva commented Oct 10, 2023

Thanks Matt, looks good!

@csinva csinva merged commit 78e3205 into master Oct 10, 2023
2 checks passed
@mepland mepland deleted the figs_notebook_update branch October 11, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mepland @csinva