-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the new API #59
base: master
Are you sure you want to change the base?
the new API #59
Conversation
@geelen Can you enlighten me about the destination of the "trace" variable? I figured out, that it should help to predictably load external modules, but I can't understand how it should work properly. |
Okay, I figured it out, how the trace should work 💃 |
Anyways, I made that pr in order to unify the implementation between require-hook and css-modulesify and fix few issues: #22, #23, #27, #16 The major change is that it uses the public parser plugin now and I added a flexibility to specify custom loader by providing function through the |
Just checking in… what's the status on this? |
@joeybaker I want to rework it, but had no free time for that. I'll to make another attempt on the next weekend. |
good stuff @sullenor - anything we can do to help? |
@sullenor this looks like it enables some nice stuff for downstream consumers of the loader – any status on when it might land? Anything outsiders can do to help out? |
@joeybaker @joshwnj @dfreeman Hi, Sorry for the late response. I talked a lot to @ai recently and decided to create a simpler version. I decided to build another two postcss plugins to resolve ICSS In my opinion it will provide simpler API for the consumers and it will be easier to share the implementation between different tools (gulp, webpack). Currently, I almost finished those plugins, so sooner or later I'll be able to send another pr. |
@sullenor I checked out your version of css-modulesify proof-of-concept, css-modules-loader-core the-new-api and postcss-modules-scope absolute-path. The paths are resolved correctly, but I'm getting the following
before any of the plugins I've specified using |
@sullenor Just checking in again since it's been a few months — how's the implementation on the other plugins looking? Is the idea that this module just becomes a lightweight layer of glue between the various constituent plugins? |
Time for the quarterly check-in: any movement here, or should we consider this repo more or less abandoned? I'm evaluating just reimplementing |
Still, I need to fix trace, but I hope this variant should be better.