Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug fix][add test case] add handle animation short name pattern case #16

Merged
merged 2 commits into from
Oct 13, 2020

Conversation

SamXChen
Copy link
Contributor

fix a bug in animation short name pattern like "animation: 2s _colon_local(fade-in);"

@Sanford284
Copy link

thank you sam, It works for me.

@alexander-akait
Copy link
Member

/cc @jquense

@SuperOleg39
Copy link

Hi!

This PR fix problem from this issue

@SamXChen sorry, can you update this PR, and maybe @evilebottnawi can merge and release it?

@alexander-akait
Copy link
Member

Need rebase

@SamXChen
Copy link
Contributor Author

Hi!

This PR fix problem from this issue

@SamXChen sorry, can you update this PR, and maybe @evilebottnawi can merge and release it?

ok, please wait a moment

fix a bug in animation short name pattern like "animation: 2s _colon_local(fade-in);"
@SamXChen
Copy link
Contributor Author

Hi!

This PR fix problem from this issue

@SamXChen sorry, can you update this PR, and maybe @evilebottnawi can merge and release it?

it's ready now

@alexander-akait alexander-akait merged commit 00ead4c into css-modules:master Oct 13, 2020
@alexander-akait
Copy link
Member

Thanks!

@SuperOleg39
Copy link

Thanks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants