Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Calculate line-height relatively depending on the font-size #18

Closed
csshugs opened this issue Oct 23, 2019 · 1 comment
Closed

[Feature] Calculate line-height relatively depending on the font-size #18

csshugs opened this issue Oct 23, 2019 · 1 comment
Assignees
@csshugs
Labels
feature New feature
Milestone
1.0.0

Comments

@csshugs
Copy link
Owner

csshugs commented Oct 23, 2019 •
edited
Loading

It’s good design practice to decrease the line-leight in relation to its font-size, the bigger the font-size gets. E.g., 1.5 might be a good line-height value for the base body copy text, but for a big, multiline headline, that value might be way too much and something like 1.2 would be much better suited.

By introducing a line-height ratio that can be defined via a Sass variable, this could be automated.
@csshugs csshugs added the feature New feature label Oct 23, 2019
@csshugs csshugs self-assigned this Oct 23, 2019
csshugs added a commit that referenced this issue Oct 23, 2019
@csshugs
feat: add line-height ratio (#18)
c266bed 
because:
- usually, big font-sizes do have a smaller line-height (in
relation to the font-size) than “normal” font-sizes do

this commit:
- introduces a new Sass variable to control the ratio with which
the line-height gets decreased, the bigger the font-size is
csshugs added a commit that referenced this issue Dec 17, 2019
@csshugs
style: fix spelling errors (#18)
db7193b
csshugs added a commit that referenced this issue Dec 17, 2019
@csshugs
docs: remove purposeless SassDoc example (#18)
d717902
@csshugs csshugs added this to the 1.0.0 milestone Dec 17, 2019
csshugs added a commit that referenced this issue Jan 6, 2020
@csshugs
feat: add line-height ratio (#18)
8932c35 
because:
- usually, big font-sizes do have a smaller line-height (in
relation to the font-size) than “normal” font-sizes do

this commit:
- introduces a new Sass variable to control the ratio with which
the line-height gets decreased, the bigger the font-size is
csshugs added a commit that referenced this issue Jan 6, 2020
@csshugs
feat: add line-height ratio (#18)
309fbcb 
because:
- usually, big font-sizes do have a smaller line-height (in
relation to the font-size) than “normal” font-sizes do

this commit:
- introduces a new Sass variable to control the ratio with which
the line-height gets decreased, the bigger the font-size is
@csshugs
Copy link
Owner Author

csshugs commented Jan 13, 2020

#19 is merged.

@csshugs csshugs closed this as completed Jan 13, 2020
csshugs added a commit that referenced this issue Feb 3, 2020
@csshugs
feat: add line-height ratio (#18)
ba469b3 
because:
- usually, big font-sizes do have a smaller line-height (in
relation to the font-size) than “normal” font-sizes do

this commit:
- introduces a new Sass variable to control the ratio with which
the line-height gets decreased, the bigger the font-size is
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csshugs csshugs

Labels
feature New feature
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@csshugs