Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add feature flag for opting out of baseline grid #2

Closed
csshugs opened this issue Sep 12, 2019 · 1 comment
Closed

[Feature] Add feature flag for opting out of baseline grid #2

csshugs opened this issue Sep 12, 2019 · 1 comment
Assignees
@csshugs
Labels
feature New feature
Milestone
1.0.0

Comments

@csshugs
Copy link
Owner

csshugs commented Sep 12, 2019

Currently, the baseline grid is without any alternative. By default, each time a font-size is declared via the fluidms-font-size() mixin, a line-height is also generated accordingly. However this could potentially lead to many line-height declarations in the compiled CSS. The advantage is that everything sits on the baseline grid. However, a baseline grid might not be needed in every project and could be considered as needless and unnecessary feature.

So the idea is to en-/disable the baseline grid via a Sass feature flag, so the user can decide if they need it or not. In case they don’t need it, a global unit-less line-height is set and the fluidms-font-size() mixin does not output any line-height declarations. However, an optional line-height can still be defined in the mixin to override the globally defined line-height.
@csshugs csshugs added the feature New feature label Sep 12, 2019
@csshugs csshugs added this to the 1.0.0 milestone Sep 12, 2019
@csshugs csshugs mentioned this issue Oct 2, 2019
Merged
@csshugs csshugs self-assigned this Oct 15, 2019
csshugs added a commit that referenced this issue Oct 23, 2019
@csshugs
feat: add feature flag for baseline grid (#2)
4ddaf2c 
because:
- not all projects require a global baseline grid
- the compiling of a line-height declaration each time a font-size
is declared may not be worth it in all cases

this commit:
- adds the ability to set the `$FLUIDMS-GLOBAL-BASELINE` to `false`
to globally disable the baseline grid
csshugs added a commit that referenced this issue Oct 23, 2019
@csshugs
feat: add feature flag for baseline grid (#2)
62fa30d 
because:
- not all projects require a global baseline grid
- the compiling of a line-height declaration each time a font-size
is declared may not be worth it in all cases

this commit:
- adds the ability to set the `$FLUIDMS-GLOBAL-BASELINE` to `false`
to globally disable the baseline grid
csshugs added a commit that referenced this issue Dec 17, 2019
@csshugs
docs: remove SassDoc example (#2)
dc68223 
because:
- we don’t need to show an example for every little detail

this commit:
- removes purposeless SassDoc comment which outputs an code
example
csshugs added a commit that referenced this issue Dec 17, 2019
@csshugs
refactor: eliminate code duplication (#2)
63fd7f7
csshugs added a commit that referenced this issue Dec 17, 2019
@csshugs
style: improve readability (#2)
0f71c07
csshugs added a commit that referenced this issue Jan 6, 2020
@csshugs
feat: add feature flag for baseline grid (#2)
3c19c6b 
because:
- not all projects require a global baseline grid
- the compiling of a line-height declaration each time a font-size
is declared may not be worth it in all cases

this commit:
- adds the ability to set the `$FLUIDMS-GLOBAL-BASELINE` to `false`
to globally disable the baseline grid
csshugs added a commit that referenced this issue Jan 6, 2020
@csshugs
docs: remove SassDoc example (#2)
a3a7186 
because:
- we don’t need to show an example for every little detail

this commit:
- removes purposeless SassDoc comment which outputs an code
example
csshugs added a commit that referenced this issue Jan 6, 2020
@csshugs
refactor: eliminate code duplication (#2)
6cd4ff1
csshugs added a commit that referenced this issue Jan 6, 2020
@csshugs
style: improve readability (#2)
8e0c936
csshugs added a commit that referenced this issue Jan 13, 2020
@csshugs
feat: add feature flag for baseline grid (#2)
e3758c9 
because:
- not all projects require a global baseline grid
- the compiling of a line-height declaration each time a font-size
is declared may not be worth it in all cases

this commit:
- adds the ability to set the `$FLUIDMS-GLOBAL-BASELINE` to `false`
to globally disable the baseline grid
csshugs added a commit that referenced this issue Jan 13, 2020
@csshugs
docs: remove SassDoc example (#2)
f31f2e1 
because:
- we don’t need to show an example for every little detail

this commit:
- removes purposeless SassDoc comment which outputs an code
example
csshugs added a commit that referenced this issue Jan 13, 2020
@csshugs
refactor: eliminate code duplication (#2)
70b2e8f
csshugs added a commit that referenced this issue Jan 13, 2020
@csshugs
style: improve readability (#2)
3762814
csshugs added a commit that referenced this issue Jan 13, 2020
@csshugs
style: reverse if-condition (#2)
050fe7a
csshugs added a commit that referenced this issue Feb 3, 2020
@csshugs
feat: add feature flag for baseline grid (#2)
7f3c279 
because:
- not all projects require a global baseline grid
- the compiling of a line-height declaration each time a font-size
is declared may not be worth it in all cases

this commit:
- adds the ability to set the `$FLUIDMS-GLOBAL-BASELINE` to `false`
to globally disable the baseline grid
csshugs added a commit that referenced this issue Feb 3, 2020
@csshugs
docs: remove SassDoc example (#2)
f9a33a1 
because:
- we don’t need to show an example for every little detail

this commit:
- removes purposeless SassDoc comment which outputs an code
example
csshugs added a commit that referenced this issue Feb 3, 2020
@csshugs
refactor: eliminate code duplication (#2)
efa048a
csshugs added a commit that referenced this issue Feb 3, 2020
@csshugs
style: improve readability (#2)
2f7e1fe
csshugs added a commit that referenced this issue Feb 3, 2020
@csshugs
style: reverse if-condition (#2)
b722e2b
@csshugs
Copy link
Owner Author

csshugs commented Feb 3, 2020

#20 is merged.

@csshugs csshugs closed this as completed Feb 3, 2020
csshugs added a commit that referenced this issue Feb 3, 2020
@csshugs
feat: add feature flag for baseline grid (#2)
0498a31 
because:
- not all projects require a global baseline grid
- the compiling of a line-height declaration each time a font-size
is declared may not be worth it in all cases

this commit:
- adds the ability to set the `$FLUIDMS-GLOBAL-BASELINE` to `false`
to globally disable the baseline grid

docs: remove SassDoc example (#2)

because:
- we don’t need to show an example for every little detail

this commit:
- removes purposeless SassDoc comment which outputs an code
example

refactor: eliminate code duplication (#2)

style: improve readability (#2)

style: reverse if-condition (#2)
csshugs added a commit that referenced this issue Feb 3, 2020
@csshugs
feat: add feature flag for baseline grid (#2)
45f2b2b 
because:
- not all projects require a global baseline grid
- the compiling of a line-height declaration each time a font-size
is declared may not be worth it in all cases

this commit:
- adds the ability to set the `$FLUIDMS-GLOBAL-BASELINE` to `false`
to globally disable the baseline grid

docs: remove SassDoc example (#2)

because:
- we don’t need to show an example for every little detail

this commit:
- removes purposeless SassDoc comment which outputs an code
example

refactor: eliminate code duplication (#2)

style: improve readability (#2)

style: reverse if-condition (#2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csshugs csshugs

Labels
feature New feature
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@csshugs