-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add feature flag for opting out of baseline grid #2
Comments
csshugs
added a commit
that referenced
this issue
Oct 23, 2019
because: - not all projects require a global baseline grid - the compiling of a line-height declaration each time a font-size is declared may not be worth it in all cases this commit: - adds the ability to set the `$FLUIDMS-GLOBAL-BASELINE` to `false` to globally disable the baseline grid
csshugs
added a commit
that referenced
this issue
Oct 23, 2019
because: - not all projects require a global baseline grid - the compiling of a line-height declaration each time a font-size is declared may not be worth it in all cases this commit: - adds the ability to set the `$FLUIDMS-GLOBAL-BASELINE` to `false` to globally disable the baseline grid
csshugs
added a commit
that referenced
this issue
Dec 17, 2019
because: - we don’t need to show an example for every little detail this commit: - removes purposeless SassDoc comment which outputs an code example
csshugs
added a commit
that referenced
this issue
Dec 17, 2019
csshugs
added a commit
that referenced
this issue
Dec 17, 2019
csshugs
added a commit
that referenced
this issue
Jan 6, 2020
because: - not all projects require a global baseline grid - the compiling of a line-height declaration each time a font-size is declared may not be worth it in all cases this commit: - adds the ability to set the `$FLUIDMS-GLOBAL-BASELINE` to `false` to globally disable the baseline grid
csshugs
added a commit
that referenced
this issue
Jan 6, 2020
because: - we don’t need to show an example for every little detail this commit: - removes purposeless SassDoc comment which outputs an code example
csshugs
added a commit
that referenced
this issue
Jan 6, 2020
csshugs
added a commit
that referenced
this issue
Jan 6, 2020
csshugs
added a commit
that referenced
this issue
Jan 13, 2020
because: - not all projects require a global baseline grid - the compiling of a line-height declaration each time a font-size is declared may not be worth it in all cases this commit: - adds the ability to set the `$FLUIDMS-GLOBAL-BASELINE` to `false` to globally disable the baseline grid
csshugs
added a commit
that referenced
this issue
Jan 13, 2020
because: - we don’t need to show an example for every little detail this commit: - removes purposeless SassDoc comment which outputs an code example
csshugs
added a commit
that referenced
this issue
Jan 13, 2020
csshugs
added a commit
that referenced
this issue
Jan 13, 2020
csshugs
added a commit
that referenced
this issue
Jan 13, 2020
csshugs
added a commit
that referenced
this issue
Feb 3, 2020
because: - not all projects require a global baseline grid - the compiling of a line-height declaration each time a font-size is declared may not be worth it in all cases this commit: - adds the ability to set the `$FLUIDMS-GLOBAL-BASELINE` to `false` to globally disable the baseline grid
csshugs
added a commit
that referenced
this issue
Feb 3, 2020
because: - we don’t need to show an example for every little detail this commit: - removes purposeless SassDoc comment which outputs an code example
csshugs
added a commit
that referenced
this issue
Feb 3, 2020
csshugs
added a commit
that referenced
this issue
Feb 3, 2020
csshugs
added a commit
that referenced
this issue
Feb 3, 2020
#20 is merged. |
csshugs
added a commit
that referenced
this issue
Feb 3, 2020
because: - not all projects require a global baseline grid - the compiling of a line-height declaration each time a font-size is declared may not be worth it in all cases this commit: - adds the ability to set the `$FLUIDMS-GLOBAL-BASELINE` to `false` to globally disable the baseline grid docs: remove SassDoc example (#2) because: - we don’t need to show an example for every little detail this commit: - removes purposeless SassDoc comment which outputs an code example refactor: eliminate code duplication (#2) style: improve readability (#2) style: reverse if-condition (#2)
csshugs
added a commit
that referenced
this issue
Feb 3, 2020
because: - not all projects require a global baseline grid - the compiling of a line-height declaration each time a font-size is declared may not be worth it in all cases this commit: - adds the ability to set the `$FLUIDMS-GLOBAL-BASELINE` to `false` to globally disable the baseline grid docs: remove SassDoc example (#2) because: - we don’t need to show an example for every little detail this commit: - removes purposeless SassDoc comment which outputs an code example refactor: eliminate code duplication (#2) style: improve readability (#2) style: reverse if-condition (#2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the baseline grid is without any alternative. By default, each time a font-size is declared via the
fluidms-font-size()
mixin, a line-height is also generated accordingly. However this could potentially lead to many line-height declarations in the compiled CSS. The advantage is that everything sits on the baseline grid. However, a baseline grid might not be needed in every project and could be considered as needless and unnecessary feature.So the idea is to en-/disable the baseline grid via a Sass feature flag, so the user can decide if they need it or not. In case they don’t need it, a global unit-less line-height is set and the
fluidms-font-size()
mixin does not output any line-height declarations. However, an optional line-height can still be defined in the mixin to override the globally defined line-height.The text was updated successfully, but these errors were encountered: