Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: do not shrink text on larger viewports #21

Closed
csshugs opened this issue Dec 20, 2019 · 1 comment
Closed

improvement: do not shrink text on larger viewports #21

csshugs opened this issue Dec 20, 2019 · 1 comment
Assignees
@csshugs
Labels
improvement Change or improve existing feature

Comments

@csshugs
Copy link
Owner

csshugs commented Dec 20, 2019

When changing (i.e. increasing) the font-size ratio for larger viewports, the font-size variants that are larger than the base font-size increase in their size, but those that are smaller than the base font-size are shrinking, which does not make sense. Essentially, the large type gets larger and the small type gets smaller.

A pragmatic approach would be to just not change the font-size of the smaller variants on larger viewports.
@csshugs csshugs added the improvement Change or improve existing feature label Dec 20, 2019
@csshugs csshugs self-assigned this Dec 20, 2019
csshugs added a commit that referenced this issue Dec 20, 2019
@csshugs
feat: stop shrinking of small type on larger viewports (#21)
b3524fa 
because:
- when the font-size ratio is increased on larger viewports,
the large type gets larger, but the small type is getting
smaller, which is not what we want

this commit:
- stops the shrinking of smaller type (i.e. smaller than the base
font-size) on larger viewports, when the ratio is changed
csshugs added a commit that referenced this issue Jan 6, 2020
@csshugs
docs: document if condition (#21)
e30155f
csshugs added a commit that referenced this issue Jan 13, 2020
@csshugs
feat: stop shrinking of small type on larger viewports (#21)
30cfd65 
because:
- when the font-size ratio is increased on larger viewports,
the large type gets larger, but the small type is getting
smaller, which is not what we want

this commit:
- stops the shrinking of smaller type (i.e. smaller than the base
font-size) on larger viewports, when the ratio is changed

docs: document if condition (#21)
csshugs added a commit that referenced this issue Jan 13, 2020
@csshugs
feat: stop shrinking of small type on larger viewports (#21)
d39b1e0 
because:
- when the font-size ratio is increased on larger viewports,
the large type gets larger, but the small type is getting
smaller, which is not what we want

this commit:
- stops the shrinking of smaller type (i.e. smaller than the base
font-size) on larger viewports, when the ratio is changed

docs: document if condition (#21)
@csshugs
Copy link
Owner Author

csshugs commented Jan 13, 2020

#22 is merged.

@csshugs csshugs closed this as completed Jan 13, 2020
csshugs added a commit that referenced this issue Feb 3, 2020
@csshugs
feat: stop shrinking of small type on larger viewports (#21)
4ae74f1 
because:
- when the font-size ratio is increased on larger viewports,
the large type gets larger, but the small type is getting
smaller, which is not what we want

this commit:
- stops the shrinking of smaller type (i.e. smaller than the base
font-size) on larger viewports, when the ratio is changed

docs: document if condition (#21)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csshugs csshugs

Labels
improvement Change or improve existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@csshugs