-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement: do not shrink text on larger viewports #21
Labels
improvement
Change or improve existing feature
Comments
csshugs
added a commit
that referenced
this issue
Dec 20, 2019
because: - when the font-size ratio is increased on larger viewports, the large type gets larger, but the small type is getting smaller, which is not what we want this commit: - stops the shrinking of smaller type (i.e. smaller than the base font-size) on larger viewports, when the ratio is changed
csshugs
added a commit
that referenced
this issue
Jan 6, 2020
csshugs
added a commit
that referenced
this issue
Jan 13, 2020
because: - when the font-size ratio is increased on larger viewports, the large type gets larger, but the small type is getting smaller, which is not what we want this commit: - stops the shrinking of smaller type (i.e. smaller than the base font-size) on larger viewports, when the ratio is changed docs: document if condition (#21)
csshugs
added a commit
that referenced
this issue
Jan 13, 2020
because: - when the font-size ratio is increased on larger viewports, the large type gets larger, but the small type is getting smaller, which is not what we want this commit: - stops the shrinking of smaller type (i.e. smaller than the base font-size) on larger viewports, when the ratio is changed docs: document if condition (#21)
#22 is merged. |
csshugs
added a commit
that referenced
this issue
Feb 3, 2020
because: - when the font-size ratio is increased on larger viewports, the large type gets larger, but the small type is getting smaller, which is not what we want this commit: - stops the shrinking of smaller type (i.e. smaller than the base font-size) on larger viewports, when the ratio is changed docs: document if condition (#21)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When changing (i.e. increasing) the font-size ratio for larger viewports, the font-size variants that are larger than the base font-size increase in their size, but those that are smaller than the base font-size are shrinking, which does not make sense. Essentially, the large type gets larger and the small type gets smaller.
A pragmatic approach would be to just not change the font-size of the smaller variants on larger viewports.
The text was updated successfully, but these errors were encountered: