Fix/warning adjustment #1170
Merged
Fix/warning adjustment #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, it is confusing to parse it because investigation pointers (rule, Component) are in the same flow as warning's text itself. This subtle change aims to put focus on important parts of the warning. Before: Warning: [JSS] Could not find the referenced rule icon in Button, Themed, Static. After Warning: [JSS] Could not find the referenced rule "icon" in "Button, Themed, Static".
|
I dont know why my test is failing, thus I will appreciate guidance. rest of the test I assume are failing from the master |
HenriBeck
approved these changes
Aug 15, 2019
iamstarkov
commented
Aug 21, 2019
| @@ -405,7 +405,7 @@ describe('jss-plugin-nested', () => { | |||
| expect(spy.callCount).to.be(1) | |||
| expect( | |||
| spy.calledWithExactly( | |||
| 'Warning: [JSS] Could not find the referenced rule "b" in ".a-id {\n & $b: [object Object];\n}."' | |||
| 'Warning: [JSS] Could not find the referenced rule "b" in ".a-id {\n & $b: [object Object];\n}".' | |||
|
merged,thx |
|
🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is confusing to parse it because investigation pointers (rule, Component)
are in the same flow as warning's text itself. This subtle change aims
to put focus on important parts of the warning.
Before:
Warning: [JSS] Could not find the referenced rule icon in Button, Themed, Static.
After
Warning: [JSS] Could not find the referenced rule "icon" in "Button, Themed, Static".