Move flow types to .flow typedef files #1509
Conversation
| } | ||
|
|
||
| declare export default class PluginsRegistry { | ||
| plugins: {| |
There was a problem hiding this comment.
Would we even need to declare this as I wouldn't consider this to be a "public" API and shouldn't really be accessed from the outside?
There was a problem hiding this comment.
yeah, was my question as well, since typings are only used from outside, I am not sure internally used types provide any additional type safety, unless used from outside, but thats not going to happen
There was a problem hiding this comment.
I think it should be removed as long as we only want to use these types for the outside and not for internal type checking
There was a problem hiding this comment.
Just tried, can't remove completely all private fields from .flow, it's still gonna be a mixture of public apis and internal once, otherwise it won't compile
There was a problem hiding this comment.
Because some fields are accessed by jss core itself, from other modules, for actual public api we would need to differentiate that and the access from public apis
Data could contain theme but it doesn't have to
kof
force-pushed
the
move-flow-to-typedefs
branch
from
e7efd5c to
117dcb8
Compare
|
I finally finished moving all flow types in all packages, once this is merged, nothing stops us from using ts |
|
merged now we can add ts types |
#1035