Ignore undefine, null, or empty value rules when generate style. #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenriBeck
requested changes
Oct 26, 2018
HenriBeck
requested changes
Oct 28, 2018
| describe('@global rule with null, undefined or empty value', () => { | ||
| let sheet | ||
|
|
||
| it('should generate correct CSS for one rule', () => { |
There was a problem hiding this comment.
This test is unnecessary and most likely already tested.
What should be tested is the following scenario:
'@global a': undefined
'@global b': null,
added 2 commits
October 28, 2018 09:14
- Renamed test to be more descriptive - Moved test suite to the bottom as this is more of an edge case - Removed rules with an empty string value as this is not a valid jss syntax
HenriBeck
approved these changes
Oct 28, 2018
This comment has been minimized.
This comment has been minimized.
HenriBeck
pushed a commit
that referenced
this pull request
Nov 16, 2018
…eact-jss/update-theming * origin/react-jss/update-theming: use https on our site remove nag message from postinstall script (#914) [docs] Add Onepixel (#912) Add TS type defs (#889) Don't use undefined as a selector (#906) Ignore undefine, null, or empty value rules when generate style. (#905) Fixed cannot find top level reference issue inside @media query (#900) Improve scripts output (#904) # Conflicts: # packages/react-jss/.size-snapshot.json
bhupinderbola
pushed a commit
to bhupinderbola/jss
that referenced
this pull request
Sep 17, 2019
…e. (cssinjs#905) *Fixed bug for throwing error when global rule is undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #899