-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First propal #1
First propal #1
Conversation
var input = fs.readFileSync("index.css", "utf8") | ||
|
||
var output = postcss() | ||
.use(cssnext()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If cssrecipes
is just using cssnext
then I think stylelint
can come first in the processor pipeline, as all the syntax in the cssnext
is supported by stylelint
. This will allow you to turn on rules like *-no-vendor-prefixes-*
and make use of things like selector-root-no-composition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, but in fact I want to use cssnext only like:
var fs = require("fs")
var cssnext = require("cssnext")
var cssrecipesConfig = require("stylelint-config-cssrecipes")
var input = fs.readFileSync("index.css", "utf8")
var output = cssnext(input, {
import: {
plugins:[
require("stylelint")(cssrecipesConfig),
require("postcss-reporter")
]
}
})
But i need to talk with @MoOx why it doesn't work right now. This example is temporary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be
cssnext(input, {
beforeTransformPlugins: [
require("stylelint")(cssrecipesConfig)
]
})
soon... MoOx/postcss-cssnext#149
Looking great! It's awesome to see a comprehensive config come together. I've added a few notes to the code. |
trim_trailing_whitespace = false | ||
|
||
[Makefile] | ||
indent_style = tab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makefile is kind of useless (also: npm script is fine most of the time ^^)
Looks good for a start :) |
ca67f4a
to
ab7ab84
Compare
lgtm right now |
I analyzed all the codebase cssrecipes and makes a config stylelint.
Here you can see what happens after normalizing the code https://gist.github.com/magsout/b17b5c29c3911056a6b1/revisions
What do you think guys ? poke @MoOx @bloodyowl
It still lacks the stylelint/stylelint#278 indentation part and multiple part selector stylelint/stylelint#285