This repository has been archived by the owner on Dec 27, 2024. It is now read-only.
feat: upgrade to PostCSS 8 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armano2
force-pushed
the
feat/postcss-8
branch
from
b4dc203 to
3bd85bc
Compare
Antonio-Laguna
suggested changes
Nov 7, 2021
There was a problem hiding this comment.
Hey @armano2!
Thanks a lot for the time you put into this PR and for getting this up to date with PostCSS 8! Really appreciate the fact you did create a GH Workflow to get this testable with GitHub actions.
I've taken a look and all seems sensible and I've just left some minor styling comments.
Nice work!
|
@Antonio-Laguna requested changes applied |
armano2
force-pushed
the
feat/postcss-8
branch
from
bc437e3 to
43c6306
Compare
Antonio-Laguna
approved these changes
Nov 8, 2021
|
Great work @armano2 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the module to PostCSS 8 along with a few other changes:
postcss-value-parsertopostcss-values-parsersee csstools/postcss-preset-env#191
ci: https://github.com/armano2/postcss-media-fn/actions/runs/1431998088