-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/postcss 8 #53
Feature/postcss 8 #53
Conversation
Trying this PR in our app. Ran into this error:
I can't be totally sure the error is from this package because there are so many packages that are seemingly having trouble with postcss 8. Here are the relevant parts of our package.json:
|
I think this happens because when you specify dependencies via Git Repository. I suggest that you clone the repository, run build locally and |
any updates on this |
I added a fork incase the package was totally dead, but then I realised that they were both owned by @jonathantneal so we'd either have to go further up the chain and fork this package too, or wait for him to merge/release. Also I think the tests need updating, too. |
Hi @radiosilence, thanks for the ping. I’m hoping I get through my workload well enough today that I can pick this up tonight. |
@jonathantneal amazing, thanks mate! Just need a version bump on this project really and then I think CRA can update and everything is golden |
This pull request upgrade to
postcss@8
The test will fail because the current version of
postcss-browser-comments
still usepostcss@7
should be merged after csstools/postcss-browser-comments#4
Related Issue
postcss-browser-comments
csstools/postcss-browser-comments#5create-react-app
cannot upgrade topostcss@8
facebook/create-react-app#9664