-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fir filter input #65
Open
jmoso13
wants to merge
10
commits into
csteinmetz1:main
Choose a base branch
from
jmoso13:fir_filter_input
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fir filter input #65
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
92cf006
add butter filter
jmoso13 2a2d899
package
jmoso13 ebd8748
again
jmoso13 4bc86c4
add sr
jmoso13 68912a3
trying digital init
jmoso13 f069d82
cleanup
jmoso13 de822db
adding prefilter input
jmoso13 c9b93e5
add custom sequential class for multiple inputs
jmoso13 9be1489
remove init
jmoso13 2759c6e
missing parentheses
jmoso13 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
add butter filter
- Loading branch information
commit 92cf006700d6d00a4c31a7f71587bc29a2ff9d48
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding the butterworth parameters to this constructor make the behavior a bit confusing since we also have the
filter_type
parameter which will get ignored. I do not know the best solution yet, but it feels like we should instead just passtaps
into this constructor. Then we will need to supply some helper functions for hp and butterworth filters that will produce a tensor of taps. What do you think?