Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in reference state calculations for model data #102

Closed
Pragallva opened this issue Dec 13, 2023 · 1 comment · Fixed by #105
Closed

Issue in reference state calculations for model data #102

Pragallva opened this issue Dec 13, 2023 · 1 comment · Fixed by #105
Labels

Comments

@Pragallva
Copy link

Pragallva commented Dec 13, 2023

While applying the class QGFieldNHN22 to a model dataset, I encountered an unrealistic reference state and negative FAWA values in the tropics which is not right (FAWA should always be positive). This issue seems to be coming from the part of the code that computes the reference state.

The code works perfectly fine when applied to ERAI and ERA5 datasets but they don't work on NorESM model output, for example. The reason being that the current version of falwa assumes dlat = dlon which is true for the case of ERA datasets but may not work for other model data where the latitude and longitude grid spacings may be different.

Good news is that this looks like an easy fix. The issue seems to be resolved when appropriate changes are made in the fortran codes, particularly in compute_qref_and_fawa_first.f90.

@csyhuang
Copy link
Owner

@Pragallva FYI I created a pull request to master for @chpolste to review which includes your commits: #105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants