Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix and hybrid coordinate example from Pragallva + additional contribution + readme files #105

Merged
merged 11 commits into from
Dec 27, 2023

Conversation

csyhuang
Copy link
Owner

This PR includes contribution by Pragallva to fix #102 : the differential area to compute reference states, $a^2 \cos\phi \Delta\phi \Delta\lambda$ , was miscomputed as $a^2 \cos\phi (\Delta\phi)^2$ . (This has not caused issues in results presented in our previous publications because we have been using ERA5 datasets with $\Delta\phi = \Delta\lambda$.)

Summary of changes:

  1. $\Delta\phi$ and $\Delta\lambda$ are precomputed in QGField object and passed into the F2PY modules as parameters
  2. Pragallva has included an example in scripts/pre_process_data_in_hybrid_coordinates/ how to preprocess climate model output in hybrid coordinate for consumption of QGField downstream by (1) transforming the fields to pressure coordinates, and (2) do gridfill over underground" gridpoints using poisson solver (as how Clare did in MDTF project)
  3. Added CONTRIBUTING.md to include instructions for potential contributors.

@chpolste please let me know if you have time to review in the coming 3 weeks. Thanks! 😊

Copy link
Collaborator

@chpolste chpolste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
No problems when running tests and building documentation on my local machine either.

@csyhuang
Copy link
Owner Author

@chpolste Thanks Christopher! I'll go ahead merge it and do a bugfix release!

@csyhuang csyhuang merged commit b723df8 into master Dec 27, 2023
3 checks passed
@csyhuang csyhuang deleted the release1.2.0 branch December 27, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue in reference state calculations for model data
2 participants