-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pointing modules fail when no time info is available #235
Comments
A suggestion, for the pointing, since it doesn't require nanosecond precision or anything close to it: |
On Tue, 3 Dec 2019 at 10:44, mdpunch ***@***.***> wrote:
A suggestion, for the pointing, since it doesn't require nanosecond
precision or anything close to it:
The fallback time for the pointing could be just the NTP time of the
machine with the event builder (as long as this has NTP set-up correctly).
So if there is neither UCTS nor TIB time, then this time would be enough to
do pointing corrections.
I would always keep that machine NTP time in the data (not just as
fallback), the decision of using it or not can be taken later, right?
… —
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#235?email_source=notifications&email_token=ADMCCOUDCUUJSRRFVQQNOZTQWYTBDA5CNFSM4JSG7PJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFYXMRY#issuecomment-561083975>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADMCCOULLOBGUQH45HBGRG3QWYTBDANCNFSM4JSG7PJA>
.
--
Abelardo Moralejo Olaizola
Institut de Física d'Altes Energies
Tel : +34 931641662
Fax: +34 935811938
Avís - Aviso - Legal Notice - (LOPD) - http://legal.ifae.es
--
Avís -
Aviso - Legal Notice - (LOPD) - http://legal.ifae.es
<http://legal.ifae.es/>
|
I am also in favor of keeping NTP time in data. By data, I think you meant in DL1 data. |
Thanks for the suggestion @mdpunch! I will run some tests in order to check if the granularity of the NTP time is enough for the pointing interpolation. I will add these timestamps as well. |
The Earth turns at 360° per day, or 15° per hour! |
I think I have mixed up several things. Let me try to clarify them:
|
I just spotted another bug in the usage of the pointing module. I tried to interpolate the pointing position for a whole run. Since in the current version of lstchain, only the time coming from the TIB is being used provided its presence flag is OK, sometimes it happens that there is no time info (it is set to -1 indeed) so the interpolation of the pointing coordinates fails.
Thus, if you try it or have done it already, it will probably fail. I suggest not using the pointing for the time being. Sorry for the inconvenience.
I will modify the code in order to add pointing info only when correct time values are available.
The text was updated successfully, but these errors were encountered: