Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing of options to Tools in onsite scripts, fix flatfield overriding config #1042

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Nov 3, 2022

Fixes #1040

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 71.65% // Head: 71.64% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (a0a0da6) compared to base (4f7e9ec).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1042      +/-   ##
==========================================
- Coverage   71.65%   71.64%   -0.02%     
==========================================
  Files         120      120              
  Lines       11301    11303       +2     
==========================================
  Hits         8098     8098              
- Misses       3203     3205       +2     
Impacted Files Coverage Δ
lstchain/scripts/lstchain_data_r0_to_dl1.py 83.52% <50.00%> (-1.00%) ⬇️
...site/onsite_create_calibration_files_with_batch.py 31.13% <50.00%> (-0.30%) ⬇️
...ain/scripts/onsite/onsite_create_drs4_time_file.py 38.46% <50.00%> (-0.61%) ⬇️
...n/scripts/onsite/onsite_create_calibration_file.py 25.78% <100.00%> (ø)
...scripts/onsite/onsite_create_drs4_pedestal_file.py 38.46% <100.00%> (ø)
...s/onsite/onsite_create_ffactor_systematics_file.py 32.43% <100.00%> (ø)
lstchain/io/data_management.py 19.29% <0.00%> (+0.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rlopezcoto rlopezcoto merged commit 7da0442 into master Nov 7, 2022
@rlopezcoto rlopezcoto deleted the pass_options branch November 7, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use_flatfield_heuristic command line vs config file disagreement
3 participants