Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

truly optional config image_modifier #1044

Merged
merged 3 commits into from
Nov 8, 2022
Merged

Conversation

vuillaut
Copy link
Member

@vuillaut vuillaut commented Nov 5, 2022

I suppose the intent was to have these optional, since a default value was defined.
However, the reading from the config was mandatory, which is a contradiction.

This PR fixes this.

rlopezcoto
rlopezcoto previously approved these changes Nov 7, 2022
@rlopezcoto rlopezcoto dismissed their stale review November 7, 2022 09:37

not passing tests

@rlopezcoto
Copy link
Contributor

sorry, I went too fast, it seems that there is a problem with the location of the variables definition and tests are not passing

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 71.65% // Head: 71.67% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (f0be353) compared to base (4f7e9ec).
Patch coverage: 69.23% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1044      +/-   ##
==========================================
+ Coverage   71.65%   71.67%   +0.01%     
==========================================
  Files         120      120              
  Lines       11301    11303       +2     
==========================================
+ Hits         8098     8101       +3     
+ Misses       3203     3202       -1     
Impacted Files Coverage Δ
lstchain/scripts/lstchain_dl1ab.py 84.61% <69.23%> (+2.26%) ⬆️
lstchain/scripts/lstchain_data_r0_to_dl1.py 83.52% <0.00%> (-1.00%) ⬇️
...ain/scripts/onsite/onsite_create_drs4_time_file.py 38.46% <0.00%> (-0.61%) ⬇️
...site/onsite_create_calibration_files_with_batch.py 31.13% <0.00%> (-0.30%) ⬇️
...n/scripts/onsite/onsite_create_calibration_file.py 25.78% <0.00%> (ø)
...s/onsite/onsite_create_ffactor_systematics_file.py 32.43% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vuillaut vuillaut requested a review from rlopezcoto November 7, 2022 19:15
@vuillaut vuillaut merged commit c6e4f85 into master Nov 8, 2022
@vuillaut vuillaut deleted the default_options_dl1ab branch November 8, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants