Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for single gain telescope to the pulse template from eventsource #1061

Merged
merged 1 commit into from
May 4, 2023

Conversation

gabemery
Copy link
Collaborator

closes #1058

This was tested on current test files temporary using telescopes [1, 6] instead of [1, 2] in the failing test since LST2-4 are in the current file.
Failure behaviour in #1058 was observed before the fix.

@gabemery gabemery requested a review from maxnoe December 13, 2022 13:47
@gabemery gabemery self-assigned this Dec 13, 2022
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 71.72% // Head: 71.72% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d17fb79) compared to base (3a04678).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1061   +/-   ##
=======================================
  Coverage   71.72%   71.72%           
=======================================
  Files         120      120           
  Lines       11316    11320    +4     
=======================================
+ Hits         8116     8119    +3     
- Misses       3200     3201    +1     
Impacted Files Coverage Δ
lstchain/data/normalised_pulse_template.py 98.68% <80.00%> (-1.32%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gabemery gabemery added the ready for review Pull request is ready for review label Jan 10, 2023
@rlopezcoto rlopezcoto merged commit 22f9974 into master May 4, 2023
@rlopezcoto rlopezcoto deleted the lhfitsinglegain branch May 4, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lhfit doesn't support single gain telescopes
2 participants