Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calibration bug fixes #1062

Merged
merged 4 commits into from
Dec 14, 2022
Merged

Calibration bug fixes #1062

merged 4 commits into from
Dec 14, 2022

Conversation

FrancaCassol
Copy link
Collaborator

Urgent PR to fix a bug that makes all pixels tagged as outliers. I am afraid that this will ask a new release for the onsite installation

@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Base: 71.72% // Head: 71.73% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d9cdf8c) compared to base (3a04678).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1062   +/-   ##
=======================================
  Coverage   71.72%   71.73%           
=======================================
  Files         120      120           
  Lines       11316    11320    +4     
=======================================
+ Hits         8116     8120    +4     
  Misses       3200     3200           
Impacted Files Coverage Δ
...site/onsite_create_calibration_files_with_batch.py 31.13% <ø> (ø)
lstchain/calib/camera/pedestals.py 96.11% <100.00%> (ø)
lstchain/visualization/plot_calib.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rlopezcoto rlopezcoto merged commit 7dc71a6 into master Dec 14, 2022
@rlopezcoto rlopezcoto deleted the calibration_bug_fixes branch December 14, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants