-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
code snippets in docs #1086
code snippets in docs #1086
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1086 +/- ##
=======================================
Coverage 71.76% 71.76%
=======================================
Files 120 120
Lines 11348 11348
=======================================
Hits 8144 8144
Misses 3204 3204 ☔ View full report in Codecov by Sentry. |
Looks good to me. I would also add the way of accessing the configuration used to produce a given file: with tables.open_file(filename) as file:
config = yaml.safe_load(file.root.dl1.event.telescope.parameters.LST_LSTCam.attrs["config"])
print(config) and maybe also which DRS4 baseline correction and calibration coefficients files were used since they are also stored as metadata in the file. |
If I merge, could you add this info in another please? |
Sure, go ahead with the merging and I will include the additional snippet
in another PR.
El vie., 5 may. 2023 9:41, Thomas Vuillaume ***@***.***>
escribió:
… Looks good to me. I would also add the way of accessing the configuration
used to produce a given file:
with tables.open_file(filename) as file:
config = yaml.safe_load(file.root.dl1.event.telescope.parameters.LST_LSTCam.attrs["config"])print(config)
and maybe also which DRS4 baseline correction and calibration coefficients
files were used since they are also stored as metadata in the file.
If I merge, could you add this info in another please?
—
Reply to this email directly, view it on GitHub
<#1086 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHZKV4JYOBBYXLJ2X3PMDA3XESVJHANCNFSM6AAAAAAXPDVNSM>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Add a code snippets section in the docs.