PR for ctapipe 0.17 : write pedestal and ff events to a h5 files #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnoe
reviewed
May 15, 2023
maxnoe
reviewed
May 15, 2023
maxnoe
reviewed
May 15, 2023
maxnoe
reviewed
May 15, 2023
FrancaCassol
force-pushed
the
ctapipe_0.17_new_write_pedestal_ff_events_to_h5
branch
from
e37c1fc to
bdb1129
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## ctapipe_0.17 #1100 +/- ##
================================================
+ Coverage 74.36% 74.57% +0.21%
================================================
Files 124 124
Lines 12208 12321 +113
================================================
+ Hits 9079 9189 +110
- Misses 3129 3132 +3
☔ View full report in Codecov by Sentry. |
rlopezcoto
reviewed
May 29, 2023
There was a problem hiding this comment.
this PR looks ok, if @maxnoe does not have additional comments, we could move on
maxnoe
reviewed
May 30, 2023
rlopezcoto
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New commit for the code in PR #1072 with correct rebase to ctapipe_0.17. It substitutes PR 1072