-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to current versions, add python 3.11 CI #1121
Conversation
it seems that the problem is still the support of python 3.8 in the ci due to the new version of gammapy, shall we drop it completely in the ci? |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## ctapipe_0.17 #1121 +/- ##
=============================================
Coverage 74.01% 74.01%
=============================================
Files 125 125
Lines 12524 12524
=============================================
Hits 9270 9270
Misses 3254 3254 ☔ View full report in Codecov by Sentry. |
@rlopezcoto Yes, dropping 3.8 is fine. Let's drop 3.8 and add a 3.11 test |
Update scikit-learn to 1.2 for 3.11 support |
aaaand matplotlib... current one is 3.7 |
The docs build also needs to run on at least 3.9 now |
just saw :D |
what about pyflakes? |
It should run on the lowest version we still support |
Now it's numpy, which we for some reason pin to excatly 1.21, I think I'd just remove the pin |
The setup.cfg still has
|
I do not see that one, the only one to be modified should be: Line 13 in 7e0f164
right? |
Ah, I looked on Master, I probably already removed it in the 0.17 branch |
uff, it was tougher than it seemed, thanks for the help @maxnoe ! |
There was a gammapy release very recently and we can also follow the latest ctapipe one