Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to current versions, add python 3.11 CI #1121

Merged
merged 11 commits into from
Jun 15, 2023

Conversation

rlopezcoto
Copy link
Contributor

There was a gammapy release very recently and we can also follow the latest ctapipe one

@rlopezcoto
Copy link
Contributor Author

it seems that the problem is still the support of python 3.8 in the ci due to the new version of gammapy, shall we drop it completely in the ci?

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7e0f164) 74.01% compared to head (d9dfc81) 74.01%.

Additional details and impacted files
@@              Coverage Diff              @@
##           ctapipe_0.17    #1121   +/-   ##
=============================================
  Coverage         74.01%   74.01%           
=============================================
  Files               125      125           
  Lines             12524    12524           
=============================================
  Hits               9270     9270           
  Misses             3254     3254           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maxnoe
Copy link
Member

maxnoe commented Jun 15, 2023

@rlopezcoto Yes, dropping 3.8 is fine.

Let's drop 3.8 and add a 3.11 test

@maxnoe
Copy link
Member

maxnoe commented Jun 15, 2023

Update scikit-learn to 1.2 for 3.11 support

@maxnoe
Copy link
Member

maxnoe commented Jun 15, 2023

aaaand matplotlib... current one is 3.7

@maxnoe
Copy link
Member

maxnoe commented Jun 15, 2023

The docs build also needs to run on at least 3.9 now

@rlopezcoto
Copy link
Contributor Author

aaaand matplotlib... current one is 3.7

just saw :D
the next one we downgrade to gammapy 1.0 and python 3.8 :P

@rlopezcoto
Copy link
Contributor Author

The docs build also needs to run on at least 3.9 now

what about pyflakes?

@maxnoe
Copy link
Member

maxnoe commented Jun 15, 2023

what about pyflakes?

It should run on the lowest version we still support

@maxnoe
Copy link
Member

maxnoe commented Jun 15, 2023

Now it's numpy, which we for some reason pin to excatly 1.21, I think I'd just remove the pin

@maxnoe
Copy link
Member

maxnoe commented Jun 15, 2023

The setup.cfg still has

    'numpy<1.22.0a0',

@rlopezcoto
Copy link
Contributor Author

I do not see that one, the only one to be modified should be:

python_requires = >=3.8

right?

@maxnoe
Copy link
Member

maxnoe commented Jun 15, 2023

Ah, I looked on Master, I probably already removed it in the 0.17 branch

@rlopezcoto
Copy link
Contributor Author

uff, it was tougher than it seemed, thanks for the help @maxnoe !

@maxnoe maxnoe changed the title Bump gammapy Update dependencies to current versions, add python 3.11 CI Jun 15, 2023
@rlopezcoto rlopezcoto merged commit fb3fe72 into ctapipe_0.17 Jun 15, 2023
@rlopezcoto rlopezcoto deleted the bump_gammapy branch June 15, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants