-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change way to access monitoring info in dl1 file #1133
Conversation
The former approach np.array(f.root[].cols.charge_mean) results now in an attempt to allocate a huge array (instead of just 2x2x1855), and hence a crash. No idea when or why the change of behaviour happened - could it be because of some change in pytables?
Is this by chance the same issue as this here? |
Yes, seems to be the same! |
In my case this is completely deterministic, but I only get it with a v0.9.13 installation at PIC. |
What is the pytables version there and how was it installed? |
Since it's when calling Anyways, the change looks good and is what is actually documented in the pytables docs |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1133 +/- ##
=======================================
Coverage 73.91% 73.91%
=======================================
Files 125 125
Lines 12547 12547
=======================================
Hits 9274 9274
Misses 3273 3273
☔ View full report in Codecov by Sentry. |
Name Version Build Channel Name Version Build Channel With the lstchain installation instructions for installing a release as user. The release was 0.9.13 |
H5py should not be in the play here at all, numpy would be more interesting to know |
numpy 1.21.6 py38h1d589f8_0 conda-forge |
Weird... that's the expected old version of numpy together with the current version of pytables... |
The former approach np.array(f.root[].cols.charge_mean) results in some cases in an attempt to allocate a huge array (instead of just 2x2x1855), and hence a crash. So far I only had this problem at PIC, using lstchain 0.9.13. No idea why...
With current main branch the same code works well at the IT cluster.
Since the new lines work in both cases, I propose to merge the change.