Patchs for Cat B calibration tool #1142
Conversation
| }, | ||
| "LSTCalibrationCalculator": { | ||
| "squared_excess_noise_factor": 1.222, | ||
| "use_scaled_low_gain": true, | ||
| "hg_lg_ratio": 17.4, |
There was a problem hiding this comment.
Can you say a few words about the change in this value?
There was a problem hiding this comment.
this is the correct ratio high gain/low gain (which is also in the default of the trailet). I honestly do not remember why the value in the json was 1 ...
| @@ -123,7 +124,7 @@ def setup(self): | |||
|
|
|||
| group_name = 'tel_' + str(tel_id) | |||
|
|
|||
| self.log.debug(f"Open output file {self.output_file}") | |||
| self.log.info(f"Open output file {self.output_file}") | |||
There was a problem hiding this comment.
Maybe a good opportunity to use the lazy formatting in logging instead of fstrings
There was a problem hiding this comment.
Actually, I prefer to keep a correspondence between the two calibration scripts (Cat-A and Cat-B), these messages are mainly one per job, do not imply calculations and they are in the main function, is this lazy stuff so important here ? (Also I find more readable this format ;-) )
| @@ -241,6 +241,7 @@ def calculate_calibration_coefficients(self, event): | |||
| if self.use_scaled_low_gain: | |||
| calib_data.unusable_pixels[constants.LOW_GAIN] = calib_data.unusable_pixels[constants.HIGH_GAIN] | |||
| calib_data.dc_to_pe[constants.LOW_GAIN] = calib_data.dc_to_pe[constants.HIGH_GAIN] * self.hg_lg_ratio | |||
| calib_data.time_correction[constants.LOW_GAIN] = calib_data.time_correction[constants.HIGH_GAIN] | |||
There was a problem hiding this comment.
Discussed offline: I asked whether we can use HG for the time correction of LG given that the two use slightly different signal paths and different readout chips, answer is yes:
No description provided.