Notebook for sensitivity calculation #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a given source in CameraFrame cordinates
the LST1 performance paper (this notebook was used for the cross-check of the published sensitivities)
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
In case it helps, here is the output as a pdf: |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1158 +/- ##
==========================================
- Coverage 73.96% 73.84% -0.13%
==========================================
Files 125 126 +1
Lines 12784 12847 +63
==========================================
+ Hits 9456 9487 +31
- Misses 3328 3360 +32 ☔ View full report in Codecov by Sentry. |
moralejo
requested review from
rlopezcoto
and removed request for
rlopezcoto
…ensitivity_calculation
…cta-lstchain into sensitivity_calculation
|
@rlopezcoto @maxnoe @morcuended , any idea why tests fail in test_create_drs4_pedestal_file? |
I think it's due to the new ctapipe_io_lst release v0.22.2, which is now being installed by the CI. The same happens in #1177 |
rlopezcoto
reviewed
Nov 21, 2023
rlopezcoto
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculates sensitivity from a Crab observation (for source-independent and source-dependent analysis)
This was used for the LST-1 performance paper - it was one of the two independent codes with which the sensitivities were computed.