Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make run_summary script work with ctar1 data, store format string #1179

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Nov 13, 2023

Counters are not used in case of CTA R1 input, so just don't compute them.

We rely on the event_time_s, event_time_qns and the event_type reported by EVB for this.

@morcuended
Copy link
Member

I don't know if it's intended but the dragon_reference_counter is still being filled in case of CTA R1 data

run_id,n_subruns,run_type,data_format,ucts_timestamp,run_start,dragon_reference_time,dragon_reference_module_id,dragon_reference_module_index,dragon_reference_counter,dragon_reference_source
15346,4,DRS4,ProtoR1.CameraEvent,1699555104225806289,1699555097000000000,1699555104225806289,0,0,3225806000,ucts
15349,3,DRS4,CTAR1.Event,-1,-1,-1,-1,-1,18446744073709551615,None
15350,2,DRS4,CTAR1.Event,-1,-1,-1,-1,-1,18446744073709551615,None

I think it is somehow not getting COUNTER_DEFAULTS but actually looking into the files for this time information (?)

@maxnoe
Copy link
Member Author

maxnoe commented Nov 13, 2023

I don't know if it's intended but the dragon_reference_counter is still being filled in case of CTA R1 data

The dtype of the dragon reference is uint64, the value filled is uint64.max

morcuended
morcuended previously approved these changes Nov 14, 2023
Copy link
Member

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failing is unrelated

@maxnoe
Copy link
Member Author

maxnoe commented Nov 14, 2023

Tests passing with fixed ctapipe_io_lst

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (644e43b) 73.96% compared to head (068af50) 73.93%.

Files Patch % Lines
lstchain/scripts/lstchain_create_run_summary.py 63.41% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1179      +/-   ##
==========================================
- Coverage   73.96%   73.93%   -0.04%     
==========================================
  Files         125      125              
  Lines       12784    12810      +26     
==========================================
+ Hits         9456     9471      +15     
- Misses       3328     3339      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxnoe maxnoe merged commit 3303fdd into main Nov 14, 2023
7 of 9 checks passed
@maxnoe maxnoe deleted the run_summary_ctar1 branch November 14, 2023 14:26
@rlopezcoto rlopezcoto mentioned this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants