Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum intensity by default to 50 p.e. in example DL3 and IRF configs #1208

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

morcuended
Copy link
Member

Also, I still find it confusing that these config files are not in lstchain/data, together with the rest of lstchain config files.
Shouldn't they be placed in the same location?

Moreover, these example config files are not included in the package data in setup.py:

    package_data={
        'lstchain': [
            'data/*',
            'resources/*',
        ],
    },

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (089891d) 74.22% compared to head (14b9d1b) 74.22%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1208   +/-   ##
=======================================
  Coverage   74.22%   74.22%           
=======================================
  Files         130      130           
  Lines       13279    13279           
=======================================
  Hits         9857     9857           
  Misses       3422     3422           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chaimain
Copy link
Contributor

I believe we had paused attempts to make the software easily usable for non-expert analyzers, and so we continued with the analysis practices that we initiated as is. Not sure if it is too late to make dedicated changes before the start of the upcoming software school...

@rlopezcoto rlopezcoto merged commit cd5f92f into main Jan 25, 2024
9 checks passed
@rlopezcoto rlopezcoto deleted the intensity_cut_DL3 branch January 25, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants