Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small update source-dependent DL3 step #1211

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Small update source-dependent DL3 step #1211

merged 2 commits into from
Feb 8, 2024

Conversation

SeiyaNozaki
Copy link
Collaborator

There are two small updates in this PR.

  1. Sort DL3 file based on event_id after stacking data frame for each assumed source position (on, off_180 etc), just not to confuse analyzers
  2. Use the same reco position (derived from the first event) for all events. The reconstructed position fields were filled with the assumed source positions (ON and OFF) for each event. ON and OFF positions were selected based on the camera frame with respect to the source position on the camera. So the assumed OFF positions in ICRS frame differed for each event in principle. But, sometimes not all OFF events are extracted for higher analysis (gammapy) mostly with pre-defined region cut (0.1 degrees, stored in the header) mostly because of the telescope tracking condition. This PR solves such issue.
    image

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd5f92f) 74.22% compared to head (59bc269) 74.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1211      +/-   ##
==========================================
+ Coverage   74.22%   74.24%   +0.01%     
==========================================
  Files         130      130              
  Lines       13279    13286       +7     
==========================================
+ Hits         9857     9864       +7     
  Misses       3422     3422              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SeiyaNozaki SeiyaNozaki requested review from chaimain and removed request for chaimain January 30, 2024 14:07
Copy link
Collaborator

@gabemery gabemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@moralejo moralejo merged commit ff993a4 into main Feb 8, 2024
9 checks passed
@moralejo moralejo deleted the update_srcdep_dl3 branch February 8, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants