Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script to compute NSB-tuning parameter for MC at the waveforms level #1212

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Script to compute NSB-tuning parameter for MC at the waveforms level #1212

merged 1 commit into from
Jan 31, 2024

Conversation

moralejo
Copy link
Collaborator

No description provided.

@moralejo moralejo requested a review from gabemery January 30, 2024 16:15
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (cd5f92f) 74.22% compared to head (7700c80) 74.13%.

Files Patch % Lines
lstchain/scripts/lstchain_tune_nsb_waveform.py 45.45% 24 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1212      +/-   ##
==========================================
- Coverage   74.22%   74.13%   -0.10%     
==========================================
  Files         130      131       +1     
  Lines       13279    13323      +44     
==========================================
+ Hits         9857     9877      +20     
- Misses       3422     3446      +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moralejo moralejo marked this pull request as ready for review January 30, 2024 17:12
rlopezcoto
rlopezcoto reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@rlopezcoto rlopezcoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabemery I think this was discussed with you, are you ok with the script?

gabemery
gabemery reviewed Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@gabemery gabemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except a small possible improvement

lstchain/scripts/lstchain_tune_nsb_waveform.py Show resolved Hide resolved
@moralejo moralejo requested a review from gabemery January 31, 2024 08:42
gabemery
gabemery approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@gabemery gabemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The answer by @moralejo makes sense.
So I approve the script and will later update things to not need to provide the path to the spe file.

@rlopezcoto rlopezcoto merged commit 6507bdd into main Jan 31, 2024
7 of 9 checks passed
@rlopezcoto rlopezcoto deleted the waveform_nsb_tuning branch January 31, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlopezcoto rlopezcoto rlopezcoto left review comments

@gabemery gabemery gabemery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moralejo @rlopezcoto @gabemery