Update notebooks pointlike IRF and DL3 creation examples #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
I guess this is necessary for your demonstration, right? |
Yes, I will use them |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1219 +/- ##
=======================================
Coverage 72.66% 72.66%
=======================================
Files 132 132
Lines 13648 13648
=======================================
Hits 9917 9917
Misses 3731 3731 ☔ View full report in Codecov by Sentry. |
rlopezcoto
approved these changes
Feb 7, 2024
|
@moralejo can you update the notebooks for the school? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the DL2 to IRF notebook, I've created a separate updated notebook focusing on the point-like IRF. For the moment I leave the old notebook that was also explaining the full-enclosure and background IRF creation (which needs to be updated as well, but there are no new DL2 MC files for using them at the moment).