Fixed bug & couple of improvements in lstchain_dvr_pixselector #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
file produced by the script contained only the information of the last subrun. Improvements in logging Now by default only 10 files (subruns) of the input set, distributed uniformly along the run, are actually processed to determine the DVR settings. This is to speed up the process (since the settings are determined for the whole run, we do not need to check all subruns).
moralejo
changed the title
moralejo
commented
Feb 26, 2024
| @@ -409,7 +459,7 @@ def main(): | |||
| if run_id != current_run_number: | |||
| current_run_number = run_id | |||
| else: | |||
| filemode == 'a' | |||
There was a problem hiding this comment.
THIS was the blunder!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1237 +/- ##
==========================================
- Coverage 72.87% 72.86% -0.01%
==========================================
Files 133 133
Lines 13797 13819 +22
==========================================
+ Hits 10054 10069 +15
- Misses 3743 3750 +7 ☔ View full report in Codecov by Sentry. |
rlopezcoto
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed long-standing BUG which made that the info in the DVR_settings file produced by the script contained only the information of the last subrun.
Improvements in logging
Now by default only 10 files (subruns) of the input set, distributed uniformly along the run, are actually processed to determine the DVR settings. This is to speed up the process (since the settings are determined for the whole run, we do not need to check all subruns).