Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LHfit : DVR based pixel selection + new ped variance extraction for MC #1245

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

gabemery
Copy link
Collaborator

@gabemery gabemery commented Mar 14, 2024

Two elements implemented for (MC) processing :

  • DVR based pixel selection for both data and MC before performing the likelihood fit. This is a small change to the pixels selected for data after volume reduction, but it allows to have the same selection in MC.
  • A new method to extract the pedestal variance in MC : extract once at the start (like it is done for data using interleaved events). This is required to keep events where the full camera is selected and to avoid bias in the extraction in the case of dvr pixel selection

Draft to extend test coverage

…ihood reconstruction and a method to extract once the pedestal variance for simulated data
@gabemery gabemery requested review from moralejo and chaimain March 14, 2024 16:43
@gabemery gabemery self-assigned this Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 95.06173% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 72.92%. Comparing base (e0f6d78) to head (d2ca6ca).
Report is 4 commits behind head on main.

Files Patch % Lines
lstchain/reco/reconstructor.py 95.52% 3 Missing ⚠️
lstchain/reco/r0_to_dl1.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1245      +/-   ##
==========================================
+ Coverage   72.81%   72.92%   +0.11%     
==========================================
  Files         133      133              
  Lines       13911    13962      +51     
==========================================
+ Hits        10129    10182      +53     
+ Misses       3782     3780       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gabemery gabemery marked this pull request as draft March 14, 2024 16:59
Copy link
Contributor

@chaimain chaimain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some simple changes based on code quality

@gabemery gabemery requested a review from chaimain March 18, 2024 19:45
@gabemery gabemery marked this pull request as ready for review March 18, 2024 19:45
@moralejo moralejo merged commit 5850732 into main Mar 21, 2024
9 checks passed
@moralejo moralejo deleted the lhfit_drv_pixel_selection branch March 21, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants