-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close EventSource instances #1316
Conversation
Avoid a lot of zombie processes when using these functions repeatedly
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1316 +/- ##
=======================================
Coverage 73.50% 73.50%
=======================================
Files 134 134
Lines 14211 14211
=======================================
Hits 10446 10446
Misses 3765 3765 ☔ View full report in Codecov by Sentry. |
better directly use the context manager:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this change, but also with the comment by maxnoe. So I will wait for its implementation before approving the PR.
I hope I didn't mess ups with the indents... I wonder if it was really worth. I will check again later, back to Draft |
Avoid a lot of zombie processes when using these functions repeatedly