Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lower rtol #202

Merged
merged 3 commits into from
Nov 5, 2019
Merged

lower rtol #202

merged 3 commits into from
Nov 5, 2019

Conversation

vuillaut
Copy link
Member

@vuillaut vuillaut commented Nov 4, 2019 •
edited
Loading

A lot of tests are not passing just because the rtol in these unit test is too low.
(I don't know exactly what changed - I don't think it comes from lstchain - anyway, rtol=1-4 is more than enough for these tests)

rlopezcoto
rlopezcoto approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@rlopezcoto rlopezcoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good, no idea what is the problem, we did not change anything regarding this...

@vuillaut vuillaut merged commit fd54bc4 into cta-observatory:master Nov 5, 2019
@vuillaut vuillaut deleted the test_src_pos branch November 5, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlopezcoto rlopezcoto rlopezcoto approved these changes

@garciagenrique garciagenrique Awaiting requested review from garciagenrique

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vuillaut @rlopezcoto