Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version #225

Merged
merged 3 commits into from
Nov 22, 2019
Merged

Conversation

rlopezcoto
Copy link
Contributor

Unfortunately, the version of the software was hardcoded and if you print it after 0.2.0 release, it will still print "0.1".
I copied the version.py script from ctapipe (pointing back to the original one) and changed also the version.

@vuillaut
Copy link
Member

Hi.
I am not sure to fully understand how this works 😅
But on my laptop it gives version unkown.

In [1]: import lstchain
In [2]: lstchain.__version__
Out[2]: 'unknown'

@rlopezcoto
Copy link
Contributor Author

Hi,
mmm... strange, it is working in mine:
In [1]: import lstchain
In [2]: lstchain.__version__
Out[2]: '0.2.0.post2+git3741767'

@vuillaut
Copy link
Member

Hi,
mmm... strange, it is working in mine:
In [1]: import lstchain
In [2]: lstchain.__version__
Out[2]: '0.2.0.post2+git3741767'

How do you install lstchain? pip install . ?

@rlopezcoto
Copy link
Contributor Author

pip install -e .

@morcuended
Copy link
Member

morcuended commented Nov 22, 2019

Hi @rlopezcoto, did you reinstall it in the container (cta environment) after fixing the version? Just checked it's still pointing to v 0.1

@rlopezcoto
Copy link
Contributor Author

Hi @morcuended, no, I realized we had the version hardcoded because I also printed the version after installing it in the IT container.
In any case, I installed it after the release and everything should be ok (please let me know if there is any problem), it is just that the printed version is going to be 0.1

@vuillaut
Copy link
Member

Hi @rlopezcoto
Could you add the following unit test in test_lstchain.py please:

def test_version_not_unkown():
    """
    Test that lstchain.__version__ is not unkown
    """
    import lstchain
    assert lstchain.__version__ is not 'unknown'

@vuillaut
Copy link
Member

Ok test is passing here.
I don't understand why but it seems that it is failing only for my install.... 🤔
I'll approve.
Can you release 0.2.1 and reinstall please?
lstchain version is copied in all metadata for provenance so that would be great to have the correct version.

@rlopezcoto rlopezcoto merged commit bd948bf into cta-observatory:master Nov 22, 2019
@rlopezcoto
Copy link
Contributor Author

Thanks!
Just installed it in La Palma and it seems to work:

In [2]: lstchain.__version__                                                                                                                                                         
Out[2]: '0.2.1'

@rlopezcoto rlopezcoto deleted the update_version branch April 9, 2020 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants