Fix analysis #226
Merged
Fix analysis #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @vuillaut, thanks for fixing it. Now I realize that with the hurry I did not test the script with recent data containing UCTS timestamps. |
morcuended
approved these changes
Nov 23, 2019
rlopezcoto
reviewed
Nov 23, 2019
There was a problem hiding this comment.
Thanks @vuillaut!
As I said in slack, I'll make another bugfix release and install it in the afternoon, in case something else pops up.
@morcuended I apologies, I suggested using astropy units because I thought the value would be used elsewhere later in the script and did not double-check in the hurry. It was good the first time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some small errors in recent updates that I discovered running scripts tonight.