Get time info from TIB #229
Conversation
|
thanks @morcuended! I'll wait for @FrancaCassol to have a look to be on the same page regarding PR#15 on ctapipe_io_lst. Then we need to
|
lstchain/reco/dl0_to_dl1.py
Outdated
| # # UCTS timestamps are nanoseconds in UNIX timestamp format and must be given in seconds | ||
| # utc_time = Time(datetime.utcfromtimestamp(ucts_timestamp / 1e9)) | ||
| # else: | ||
| start_ntp = event.lst.tel[telescope_id].svc.date |
There was a problem hiding this comment.
So, now it avoids UCTS time and uses TIB time. This is what you were using before you incorporated UCTS time, right? If so, it seems ok to me.
There was a problem hiding this comment.
Yes, this is how I was first taking time info
There was a problem hiding this comment.
Ok, it is then already tested. It should be fine then. Let's then wait for @FrancaCassol's comments
|
After the merging of `https://github.com/cta-observatory/ctapipe_io_lst/pull/15 one can simplify the code just using the R0/R1 event trigger_time which is now the TIB time (TAI time in s). |
|
Yes @FrancaCassol , I will fix it |
@FrancaCassol @rlopezcoto I just modified the code to take directly the time info from the trigger_time field. Please have a look. |
There was a problem hiding this comment.
It looks good to me, thanks @morcuended! I'll wait for @FrancaCassol to have a look.
|
Yes! That's fine |
Until the timing information from UCTS is well tested and trustable, we will use only TIB time information for the time being (see #227)