-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change misleading script names, solves #329 #334
Change misleading script names, solves #329 #334
Conversation
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
==========================================
+ Coverage 42.88% 43.59% +0.70%
==========================================
Files 70 69 -1
Lines 4694 4618 -76
==========================================
Hits 2013 2013
+ Misses 2681 2605 -76
Continue to review full report at Codecov.
|
Maybe keep the dl1 in the muon script? Just for clarity? |
Following #329, I changed:
dl0_to_dl1.py
=>r0_to_dl1.py
lstchain_mc_dl1_to_dl2.py
=>lstchain_dl1_to_dl2.py
lstchain_data_muon_analysis_dl1.py
=>lstchain_muon_analysis.py
and the scripts/tests/notebooks where they were called