Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add functions to read instrument info from DL1 file #468

Merged
merged 7 commits into from
Jul 10, 2020

Conversation

vuillaut
Copy link
Member

@vuillaut vuillaut commented Jul 9, 2020

Necessary as long there is no DL1 event source

lstchain/io/io.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #468 into lstchain_ctapipe0.8 will decrease coverage by 0.23%.
The diff coverage is 20.89%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           lstchain_ctapipe0.8     #468      +/-   ##
=======================================================
- Coverage                41.71%   41.47%   -0.24%     
=======================================================
  Files                       76       76              
  Lines                     6207     6273      +66     
=======================================================
+ Hits                      2589     2602      +13     
- Misses                    3618     3671      +53     
Impacted Files Coverage Δ
lstchain/io/io.py 70.48% <20.89%> (-11.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c17bde...298efef. Read the comment docs.

@vuillaut vuillaut marked this pull request as ready for review July 9, 2020 19:36
@vuillaut
Copy link
Member Author

vuillaut commented Jul 9, 2020

I have absolutely no idea why the test is failing on something completely unrelated and that is working fine otherwise: CameraDisplay(geom, image)
astropy version ?

@rlopezcoto
Copy link
Contributor

I have absolutely no idea why the test is failing on something completely unrelated and that is working fine otherwise: CameraDisplay(geom, image) astropy version ?

I'm getting those tests pass in my local version of this PR, are they also passing in your computer?

@vuillaut
Copy link
Member Author

I have absolutely no idea why the test is failing on something completely unrelated and that is working fine otherwise: CameraDisplay(geom, image) astropy version ?

I'm getting those tests pass in my local version of this PR, are they also passing in your computer?

yes they are.
It must be an install problem but it does not seem to replicate on other PRs... 🙄

@rlopezcoto
Copy link
Contributor

then, let's move on...

@vuillaut vuillaut merged commit 333d883 into cta-observatory:lstchain_ctapipe0.8 Jul 10, 2020
@vuillaut vuillaut deleted the read_array branch July 10, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants