Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed initialization of charge and peak_time arrays #483

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Fixed initialization of charge and peak_time arrays #483

merged 1 commit into from
Jul 20, 2020

Conversation

moralejo
Copy link
Collaborator

Current version does not work for new (r0 ro dl1 stage in real data). This seems to fix it.

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #483 into lstchain_ctapipe0.8 will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           lstchain_ctapipe0.8     #483   +/-   ##
====================================================
  Coverage                42.04%   42.04%           
====================================================
  Files                       76       76           
  Lines                     6288     6288           
====================================================
  Hits                      2644     2644           
  Misses                    3644     3644           
Impacted Files Coverage Δ
lstchain/calib/camera/calibrator.py 28.39% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58588cb...92e6316. Read the comment docs.

@vuillaut
Copy link
Member

Thanks for the quick fix. I don't understand how tests were passing before...

@moralejo moralejo merged commit 275ac8b into cta-observatory:lstchain_ctapipe0.8 Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants