Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding back event_id and obs_id in dl1 tables #546

Merged
merged 7 commits into from
Oct 29, 2020

Conversation

vuillaut
Copy link
Member

event_id and obs_id disappeared from the dl1 image table with ctapipe v0.8

add simple test to check if these parameters are present in the file after r0 to dl1

@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #546 into master will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #546      +/-   ##
==========================================
+ Coverage   38.61%   38.72%   +0.10%     
==========================================
  Files          79       79              
  Lines        7077     7089      +12     
==========================================
+ Hits         2733     2745      +12     
  Misses       4344     4344              
Impacted Files Coverage Δ
lstchain/io/io.py 80.95% <100.00%> (ø)
lstchain/reco/r0_to_dl1.py 62.37% <100.00%> (ø)
lstchain/tests/test_lstchain.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcb7c64...8d0afab. Read the comment docs.

@vuillaut vuillaut added the ready for review Pull request is ready for review label Oct 26, 2020
@vuillaut vuillaut requested review from rlopezcoto and maxnoe October 29, 2020 09:00
@vuillaut vuillaut merged commit 92720ba into cta-observatory:master Oct 29, 2020
@vuillaut vuillaut deleted the event_id_tab branch October 29, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants